Various Yealink fixes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file order scrambled - T3X phones like to see one section once, not repeated several times.
|
exp38_22.xml was a duplicate of exp38.xml and wasn't referenced by any other file - it's just a clean up. |
|
No problem. :) It is a little counter-intuitive, I agree. |
|
Yes thanks rjch-au. I didn't read your merge message until after I posted that. So it was my bad. |
jmcguirl
added a commit
to jmcguirl/Provisioner
that referenced
this pull request
Jul 6, 2017
This change addresses @sonic331va concerns and also allows 7, 10, 11 digit dialing... For 7 & 10 digit dialing, outbound rules need to be setup to: Rule 1. Add 1 + "area code" for 7 digit numbers ie. Prepend=(1222) Prefix="Field Left Blank" MatchPattern=NXXXXXX Rule 2. Add 1 for 10 digit numbers ie. Prepend=(1) Prefix="Field Left Blank" MatchPattern=NXXNXXXXXX Rule 3. Allow 11 digit dialing ie. Prepend="Field Left Blank" Prefix="Field Left Blank" MatchPattern=1NXXNXXXXXX Resulting behavior assuming appropriate outbound rules have been configured as above: 7 digit numbers - After dialing a 7 digit number AND the Cisco "Default Interdigit_Short_Timer" of 3 seconds expires, the 7 digits are sent from the phone. Then, outbound rule #1 adds a 1 + the area code configured in the rule to the 7 dialed digits. ie. if rule #1 is set as above... When you dial 3334444 on the phone, it adds a 1 + 222 in front of 3334444 and the PBX sends 12223334444 to the trunk. 10 digit numbers - After dialing 10 digits, the 10 digits are sent immediately (S0) from the phone. Then, outbound rule provisioner#2 adds a 1 as configured in the rule to the 10 dialed digits. ie. if rule provisioner#2 is set as above... When you dial 2223334444 on the phone, it adds a 1 in front of 2223334444 and the PBX sends 1222333444 to the trunk. 11 digit numbers - allowing 11 digit numbers to send immediately (S0) from the phone. Then, outbound rule provisioner#3 does not modify the 11 dialed digits. ie. if rule provisioner#3 is set as above... When you dial 12223334444 on the phone, the PBX simply sends 12223334444 to the trunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to Yealink phone package including:-
! Properly commit dialplan_22.xml for T2x and T3x and dialplan.xml for T3x families.
! Fix to $mac.cfg for T3x family so line keys, DSS keys and EXT38 keys are always correctly configured
! Added experimental support for EXP39s - allow 40 keys and add ability to label each key.
! Removed exp38_22.xml file for T2x and T3x families which isn't used anywhere.