Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco spa: Update template_data.json #216

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Conversation

sonic331va
Copy link
Contributor

Remove "| <:1352>[2-9]xxxxxx" from default dial plan as this prefixes 1352 to all 7 digit numbers and strips the dialed area code from a 10 digit number then prefixes 1352 to the remaining 7 dialed digits before passing the number to the PBX or SIP provider.

Remove "| <:1352>[2-9]xxxxxx" from default dial plan as this prefixes 1352 to all 7 digit numbers and strips the dialed area code from a 10 digit number then prefixes 1352 to the remaining 7 dialed digits before passing the number to the PBX or SIP provider.
@sonic331va sonic331va changed the title Update template_data.json Cisco spa: Update template_data.json Mar 24, 2017
@tm1000 tm1000 merged commit 5364e53 into provisioner:master Jun 29, 2017
@jmcguirl
Copy link
Contributor

jmcguirl commented Jun 29, 2017

This breaks 7 digit dialing. It does NOT strip a dialed area code from a 10 number. This dial plan has been in endpoint manager for five years now.

@sonic331va
Copy link
Contributor Author

And I've had to fix it every time I've used endpoint manager for the past five years. You should be using OUTBOUND dialing rules in your own PBX box to add an appropriate area code for a 7 digit number. It should not be part of the phone dial plan template. This was tested across multiple FreePBX boxes.

Removing this part of the dial plan from the template and adding the appropriate outbound rules to the PBX ensures the PHONE does not dial "1352" automatically while ignoring the user-dialed area code. It also ensures the PHONE will not add "1352" automatically to a user-dialed 7 digit number.

@jmcguirl
Copy link
Contributor

jmcguirl commented Jul 6, 2017

I agree "OUTBOUND dialing rules" is the appropriate place to add an appropriate area code for a 7 digit number. However, your version of the dialplan NEVER passes a 7 digit number. Nowhere, does it accept 7 digits.

Detailed Explanation of Cisco SPA Dialplans

<:1352>[2-9]xxxxxx" from default dial plan as this prefixes 1352 to all 7 digit numbers

The above is an accurate statement.

and strips the dialed area code from a 10 digit number then prefixes 1352 to the remaining 7 dialed digits before passing the number to the PBX or SIP provider.

The above is an INCORRECT statement. The dial plan does not strip ANY digits at any time. Values to be stripped must be placed BEFORE the ":".

SOME EXAMPLES:
An example of stripping digits would be as follows:
<1555:>[2-9]xxxxxx
The above code strips 1555 from an 11 digit number ONLY beginning with 1555.
If one were to dial 15556667788, the resulting number sent from the phone would be 6667788.

An example of "replacing" any area code would be as follows:
<1[2-9]xx:1999>[2-9]xxxxxx
The above code strips ANY area code from an 11 digit number and replaces the area code with 999.
If one were to dial 13525551212 or 12155551212, the resulting number sent from the phone would be 19995551212.

@jmcguirl
Copy link
Contributor

jmcguirl commented Jul 6, 2017

@sonic331va my Pull Request #223 addresses both of our concerns. Thank you so much for pointing this out. This update was only 5 years overdue. Open Source Development Rocks!!!

PS: This dial plan changes were tested on a spa525G with Firmware Ver.: 7.6.2 and Hardware Ver.: 2.1.1 prior to posting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants