Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for tokens restricted with attributes #1377

Merged

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Feb 17, 2023

Description

Adds support for allowing sends when defined attributes are present in receiver of funds.

closes: #1256


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 added marker Marker Module attribute Attribute Module labels Feb 17, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.15.0 milestone Feb 17, 2023
@nullpointer0x00 nullpointer0x00 self-assigned this Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1377 (1968c83) into main (fa0a515) will increase coverage by 0.06%.
The diff coverage is 74.01%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1377      +/-   ##
==========================================
+ Coverage   59.60%   59.67%   +0.06%     
==========================================
  Files         195      196       +1     
  Lines       24406    24528     +122     
==========================================
+ Hits        14547    14636      +89     
- Misses       8763     8787      +24     
- Partials     1096     1105       +9     
Impacted Files Coverage Δ
x/marker/keeper/genesis.go 12.50% <0.00%> (-0.27%) ⬇️
x/marker/types/marker.go 78.37% <11.11%> (-2.85%) ⬇️
x/marker/keeper/msg_server.go 21.50% <45.45%> (+0.51%) ⬆️
x/marker/keeper/proposal_handler.go 61.02% <50.00%> (ø)
cmd/provenanced/cmd/genaccounts.go 40.84% <66.66%> (-0.09%) ⬇️
x/marker/keeper/send_restrictions.go 74.46% <74.46%> (ø)
x/marker/keeper/marker.go 51.18% <75.00%> (-0.22%) ⬇️
x/marker/client/cli/tx.go 62.80% <85.00%> (+0.32%) ⬆️
app/app.go 82.95% <100.00%> (+0.02%) ⬆️
x/marker/keeper/keeper.go 84.74% <100.00%> (-0.97%) ⬇️
... and 3 more

x/marker/types/msg.go Outdated Show resolved Hide resolved
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) March 23, 2023 19:46
@nullpointer0x00 nullpointer0x00 merged commit e5b6c14 into main Mar 23, 2023
@iramiller iramiller deleted the 1256-support-for-tokens-restricted-with-attributes branch May 16, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attribute Attribute Module marker Marker Module
Projects
Development

Successfully merging this pull request may close these issues.

Support for Tokens Restricted with Attributes
3 participants