Fixes units in Python writer default bounds #311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no user-provided bounds provided in the writer (as in: min/max_lat/lng_e7 properties) the writer mistakenly defaults to -180,-90,180,90 for these properties.
PMTiles/python/pmtiles/tile.py
Lines 277 to 283 in e1228f5
But these properties need to be multiplied by 10000000 as seen e.g. in this examples and as indicated by the "_e7" postfix
PMTiles/python/examples/create_raster_example.py
Lines 29 to 32 in e1228f5
Without this fix we were seeing pmtiles with bounds around null island, because the order of magnitude was wrong.