Skip to content

Commit

Permalink
upb: split out :status as a separate build target
Browse files Browse the repository at this point in the history
This should allow other upb components to depend upon the zcis without causing a cycle

PiperOrigin-RevId: 486987806
  • Loading branch information
ericsalo authored and copybara-github committed Nov 8, 2022
1 parent a77b966 commit aec12a4
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
18 changes: 17 additions & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ cc_library(
"upb/internal/unicode.h",
"upb/msg.c",
"upb/msg_internal.h",
"upb/status.c",
"upb/upb.c",
"upb/wire/decode.c",
"upb/wire/encode.c",
Expand Down Expand Up @@ -149,6 +148,7 @@ cc_library(
":fastdecode",
":mem",
":port",
":status",
":table_internal",
":unicode_internal",
":wire_internal",
Expand Down Expand Up @@ -1013,6 +1013,19 @@ cc_library(
],
)

cc_library(
name = "status",
srcs = [
"upb/status.c",
],
hdrs = [
"upb/status.h",
],
copts = UPB_DEFAULT_COPTS,
visibility = ["//:__subpackages__"],
deps = [":port"],
)

cc_library(
name = "atoi_internal",
srcs = ["upb/internal/atoi.c"],
Expand Down Expand Up @@ -1100,6 +1113,7 @@ upb_amalgamation(
":port",
":reflection",
":reflection_internal",
":status",
":upb",
":wire_internal",
],
Expand Down Expand Up @@ -1135,6 +1149,7 @@ upb_amalgamation(
":port",
":reflection",
":reflection_internal",
":status",
":table_internal",
":unicode_internal",
":upb",
Expand Down Expand Up @@ -1173,6 +1188,7 @@ upb_amalgamation(
":port",
":reflection",
":reflection_internal",
":status",
":table_internal",
":unicode_internal",
":upb",
Expand Down
5 changes: 3 additions & 2 deletions upb/io/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ cc_library(
name = "string",
hdrs = ["string.h"],
deps = [
"//:upb",
"//:mem",
"//:port",
],
)
Expand Down Expand Up @@ -37,8 +37,9 @@ cc_library(
"zero_copy_output_stream.h",
],
deps = [
"//:upb",
"//:mem",
"//:port",
"//:status",
],
)

Expand Down

0 comments on commit aec12a4

Please sign in to comment.