Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #8966 into 3.17.x #8981

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

jtattermusch
Copy link
Contributor

Backports #8966.

@acozzette
Copy link
Member

acozzette commented Sep 22, 2021

@jtattermusch Are you sure you need this fix on the 3.17.x branch? We're probably not going to be doing any more 3.17.x releases.

@jtattermusch
Copy link
Contributor Author

@jtattermusch Are you sure you need this fix on the 3.17.x branch? We're probably going to be doing any more 3.17.x releases.

I'd say let's merge it anyway

  • Even in case we're not going to make any more 3.17.x release, the PR on the branch AFTER the release tag makes it clear that this fix in not included.
  • In case we decide to do a patch release for 3.17.x, this is going to be ready.

Btw, without this fix, the python aarch64 linux wheels we published for 3.17.x release are broken (their python_cpp layer won't work, only the pure python version will be usable) - just mentioning that to make the impact clear.

@acozzette acozzette merged commit 5500c72 into protocolbuffers:3.17.x Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants