-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Field Presence doc #8959
Conversation
Updated information surrounding the usage of `optional` and the `--experimental_allow_proto3_optional` flag with relevant information between v3.12 & 3.15. Since release v3.15: > Optional fields for proto3 are enabled by default, and no longer require > the --experimental_allow_proto3_optional flag.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
docs/field_presence.md
Outdated
@@ -198,10 +198,10 @@ If client A depends on _explicit presence_ for `foo`, then a "round trip" throug | |||
|
|||
## How to enable _explicit presence_ in proto3 | |||
|
|||
These are the general steps to use the experimental field tracking support for proto3: | |||
These are the general steps to u field tracking support for proto3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "use"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Fixed that up
Updated information surrounding the usage of
optional
and the--experimental_allow_proto3_optional
flag with relevant information between v3.12 & 3.15.Since release v3.15:
Now the doc infers the feature is implicitly enabled, rather than an experimental flag which was only true up until v3.15.0
see notes on optional/
--experimental_allow_proto3_optional
here: