Let GOOGLE_COMPILE_ASSERT use static_assert if available. #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation is that gcc 4.8+ and clang trunk warn on unused local typedefs, which COMPILE_ASSERT adds. After this change, the warning will be happy at least in C++11 builds. static_assert also produces a slighly nicer diagnostic than the typedef method. google/re2@eb93e8b did the same change in re2.
nico
changed the title
|
I'm going to merge this in Chromium: https://codereview.chromium.org/1242603003/ |
|
@pherl to review this. |
|
The change looks good to me. @pherl is working on refactoring these header files and we may need to hold this PR until the refactoring is done. |
|
LGTM |
liujisi
added a commit
that referenced
this pull request
Jul 21, 2015
Let GOOGLE_COMPILE_ASSERT use static_assert if available.
JulienIsorce
pushed a commit
to Samsung/ChromiumGStreamerBackend
that referenced
this pull request
Jul 27, 2015
This merges protocolbuffers/protobuf#621 BUG=411648 Review URL: https://codereview.chromium.org/1242603003 Cr-Commit-Position: refs/heads/master@{#339353}
scheib
pushed a commit
to scheib/chromium
that referenced
this pull request
Jul 27, 2015
This merges protocolbuffers/protobuf#621 BUG=411648 Review URL: https://codereview.chromium.org/1242603003 Cr-Commit-Position: refs/heads/master@{#339353}
adellahlou
pushed a commit
to adellahlou/protobuf
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is that gcc 4.8+ and clang trunk warn on unused local
typedefs, which COMPILE_ASSERT adds. After this change, the warning
will be happy at least in C++11 builds. static_assert also produces a
slighly nicer diagnostic than the typedef method.
google/re2@eb93e8b
did the same change in re2.