Added Ruby to conformance tests. #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involved fixing a few important bugs in the Ruby implementation -- mostly cases of mixing upb field types and descriptor types (upb field types do not distinguish between int/sint/fixed/sfixed like descriptor types do). Also added protobuf-specific exceptions so parse errors can be caught specifically. Change-Id: Ib49d3db976900b2c6f3455c8b88af52cfb86e036
haberman
force-pushed
the
ruby-conformance
branch
from
b62bf1d to
181c7f2
Compare
| test_message = Conformance::TestAllTypes.decode_json(request.json_payload) | ||
|
|
||
| when nil | ||
| raise "Request didn't have payload."; |
There was a problem hiding this comment.
remove semi-colon.
period could either be added on other lines or removed here, for consistency.
Change-Id: Id008ebac5159f773e1bde8b85acb2626cbd16de8
Change-Id: If7b1cc0f03f609a7f43ddafc8509b44207c60910
|
PTAL, I have integrated all of these comments. Thanks! |
|
LGTM 👍 |
haberman
added a commit
that referenced
this pull request
Jul 20, 2015
Added Ruby to conformance tests.
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
…tocolbuffers#604) 32a84b2 added a newline that resulted in the interface doc comment becoming detached from the interface type definition. However, both it and the corresponding server comment were inconsistent, so this change makes them all consistent and well-rendered in godoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved fixing a few important bugs in the
Ruby implementation -- mostly cases of mixing
upb field types and descriptor types (upb field
types do not distinguish between int/sint/fixed/sfixed
like descriptor types do).
Also added protobuf-specific exceptions so parse
errors can be caught specifically.
Change-Id: Ib49d3db976900b2c6f3455c8b88af52cfb86e036