Add terminating character to zend_lookup_class call #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you send this PR to 3.7.x branch instead? |
|
Or could you send a cherryp-pick PR to 3.7.x after this is merged? |
TeBoring
approved these changes
Mar 13, 2019
|
Sure thing! |
|
Thanks for the fix! |
dwsupplee
added a commit
to dwsupplee/protobuf
that referenced
this pull request
Mar 13, 2019
…5871) * add terminating character * adjust name length input * add test cases * correct script name * Misc fixes * add new script to EXTRA_DIST list
TeBoring
pushed a commit
that referenced
this pull request
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5837
It turns out for PHP5
zend_lookup_classexpects a null terminated string.