using ::isnan to avoid conflicts with std::isnan for C++11 build. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I057b44eff04c3b0062a4fd4307ce6e4ca1eb952b
|
LGTM |
liujisi
added a commit
that referenced
this pull request
Jun 18, 2015
using ::isnan to avoid conflicts with std::isnan for C++11 build.
taoso
pushed a commit
to taoso/protobuf
that referenced
this pull request
Aug 1, 2018
…uffers#508) In Go 1.10, go vet and gofmt have changed their output in a way to breaks the current build and test cycle. gofmt turns a one-line definition of a single-method interface into three lines; this causes a golden comparison test to produce different results between Go 1.9 and Go 1.10. go vet is now run by default with go test, which uncovered a bad Stringer argument in extension_test.go. Tested on Go1.10rc1 and Go1.9.3.
adellahlou
pushed a commit
to adellahlou/protobuf
that referenced
this pull request
Apr 20, 2023
…num value options (no wrapper), fixes protocolbuffers#510; expose zero on LongBits, fixes protocolbuffers#508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.