Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes ignored const from return type #2915

Conversation

Jdavid1001-zz
Copy link

See #2425

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@bazel-io
Copy link

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Mar 28, 2017

ok to test

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Mar 29, 2017

@Jdavid1001 The CLA bot complaints about you not signing google CLA. I guess you haven't added your account to google organization?

@Jdavid1001-zz
Copy link
Author

@xfxyjwf I've joined Google now. Does that make it fine?

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Mar 29, 2017

Can you reply as instructed by the google bot?

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@Jdavid1001-zz
Copy link
Author

I signed it!

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Mar 29, 2017

@Jdavid1001 The signcla checker still reports you haven't signed Google CLA.

@Jdavid1001-zz Jdavid1001-zz force-pushed the fix_ignored_qualifier_const_pointer branch from 4b73b89 to 6c73af1 Compare March 29, 2017 18:27
@googlebot
Copy link

CLAs look good, thanks!

@Jdavid1001-zz
Copy link
Author

Had to recommit with my @google.com email. Please let me know if there are any other concerns.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Mar 29, 2017

Thanks!

@xfxyjwf xfxyjwf merged commit 4a0dd03 into protocolbuffers:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants