Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support grpc plugin in py_proto_library #2404

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Support grpc plugin in py_proto_library #2404

merged 1 commit into from
Nov 22, 2016

Conversation

wiktortomczak
Copy link
Contributor

Inspired by cc_proto_library(..., use_grpc_plugin=True).

Note: py_proto_library(..., use_grpc_plugin=True) depends on //external:grpc_python_plugin. The latter must be defined via bind() in WORKSPACE, eg.

bind(
name = "grpc_python_plugin",
actual = "@com_github_grpc_grpc//:grpc_python_plugin"
)

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@wiktortomczak
Copy link
Contributor Author

Signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Nov 22, 2016

LGTM

Thanks for the patch!

@xfxyjwf xfxyjwf merged commit c950471 into protocolbuffers:master Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants