Fixed JSPB test failures #2400
Merged
Fixed JSPB test failures #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfxyjwf
reviewed
Nov 21, 2016
| @@ -1049,13 +1049,7 @@ describe('Message test suite', function() { | |||
| var nested = new proto.jspb.test.Deeply.Nested.Message(); | |||
| nested.setCount(5); | |||
| msg.setDeeplyNestedMessage(nested); | |||
|
|
|||
| // After a serialization-deserialization round trip we should get back the | |||
There was a problem hiding this comment.
Why is this serialize/deserialize roundtrip removed?
There was a problem hiding this comment.
I found that we don't currently generate fromObject methods (the code for it exists in js_generator.cc but is never called), so it seemed simplest to just avoid doing the round trip.
There was a problem hiding this comment.
Does it still have the same test coverage? I thought the original bug can only be revealed after a round-trip. Is it not the case?
There was a problem hiding this comment.
You're right, I went ahead and added the binary serialization round trip back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.