Fix #2036 (Ruby hash broken for Messages with repeated fields.)
#2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a repeated field to the tested hash * also assert that two messages with identical values produce identical hashes
Instead of shifting/xoring the hash at each field, use the built-in ruby apis for generating a hash from multiple input values. Now returns a Fixnum.
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test. |
|
@haberman Are you the right person to review this? thx! |
|
Ack sorry for the delay on this! |
|
Oh, looks like this caused a breakage in JRuby: https://travis-ci.org/google/protobuf/jobs/160942507 |
|
@haberman Interesting. I think this should actually be considered a second bug in JRuby that this new test exposed. I.e. the hashes of two messages with identical values should be identical, but in this case they are not. If you agree with that assessment, I'd be happy to open another issue and look into the fix. |
|
@abscondment that sounds like a reasonable assessment, thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2036 spells out how the
hashfunction is broken in many Ruby messages. This PR fixes that.