Fixes extra whitespace on generated comments. #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test. |
| // If not a one line, need to add the first space before *, as | ||
| // StripWhitespace would have removed it. | ||
| line = (is_one_line ? "" : " ") + line; | ||
| final_comments += line + suffix; |
There was a problem hiding this comment.
What is we drop the \n from both suffixes, then I think you can just do:
line = prefix + line + suffix
StripWhiteSpace(&line)
final_comments += line + "\n"
And there's isn't the special knowledge about oneline needing the space back.
There was a problem hiding this comment.
Scratch that, it still eats the leading space.
liujisi
pushed a commit
to liujisi/protobuf
that referenced
this pull request
Aug 17, 2016
Fixes extra whitespace on generated comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.