Change placement of DebuggerNonUserCodeAttribute #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this has caught everything. I've left a stub for attributes to be applied to the types themselves, but we don't currently need anything. Follow-up commit will include the changes to generated code itself. Fixes protocolbuffers#1671.
jskeet
force-pushed
the
attribute-placement
branch
from
8053c88 to
c534845
Compare
|
Reassigned to @pherl is @jtattermusch is away. The Travis build failures are the ones afflicting the whole project, not just this PR. |
|
I added @anandolee to take a look. |
| printer->Print("[global::System.Diagnostics.DebuggerNonUserCodeAttribute]\n"); | ||
| } | ||
|
|
||
| void SourceGeneratorBase::WriteGeneratedTypeAttributes(io::Printer* printer) { |
There was a problem hiding this comment.
It is a waste to have this empty method for future use only.
Let's add this when really needed.
There was a problem hiding this comment.
My reasoning for keeping it was that we've already done the work to make sure it's called at all the right places. But I don't mind removing it - let's just make sure we keep that removal as a separate commit which is easy to revert. Will add that commit to this PR.
|
LGTM |
|
Thanks. Will look into the CI failures, and submit if they're unrelated. |
This does not affect the generated code. If we decide we want to apply attributes to generated types, we should start by just reverting this change.
jskeet
force-pushed
the
attribute-placement
branch
from
1cabcd7 to
e9a7fc8
Compare
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
Change placement of DebuggerNonUserCodeAttribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1671.