Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing alias targets for C++ util libraries (cherry-pick) #15783

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

acozzette
Copy link
Member

Until recently, these targets were dependencies of //:protobuf and could thus be accessed through that target. But now that we are adhering to the layering check, we need to provide proper access in a way that respects that check. This change uses top-level alias targets following the existing pattern.

PiperOrigin-RevId: 605123979

Until recently, these targets were dependencies of `//:protobuf` and could thus
be accessed through that target. But now that we are adhering to the layering
check, we need to provide proper access in a way that respects that check. This
change uses top-level alias targets following the existing pattern.

PiperOrigin-RevId: 605123979
@acozzette acozzette requested a review from a team as a code owner February 8, 2024 21:57
@acozzette acozzette requested review from zhangskz and removed request for a team February 8, 2024 21:57
@acozzette acozzette added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 8, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 8, 2024
@acozzette acozzette merged commit 62e7a56 into protocolbuffers:26.x Feb 8, 2024
153 of 154 checks passed
@acozzette acozzette deleted the cherry-pick-alias-fix branch February 8, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants