Hide ruby native extension symbols on FreeBSD #10832
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hm. That commit message needs editing. I wonder if all the build checks will restart if I just update it? |
|
I would need to manually kick off the builds again, but I'm happy to do that if you want to edit the commit message. |
They probably should be hidden on every ELF platform, but for now only do it on Darwin, Linux, and FreeBSD. This prevents some load-time errors that have been seen in GitLab's gitaly server, and in a few other places.
|
Sure, now the commit message doesn't look like somebody who got distracted while writing it ;) |
|
This relates to this FreeBSD review. |
|
Anybody else who should be added to help review this? |
If more than one version of this gem is installed it causes segfaults. The problem is reported also here: https://gitlab.com/gitlab-org/gitlab/-/issues/345693 I created a merge request upstream for this patch: protocolbuffers/protobuf#10832 protocolbuffers/protobuf#11029 PR: 266925 Approved by: sunpoet (maintainer timeout) Differential Revision: https://reviews.freebsd.org/D37140
They probably should be hidden on every ELF platform, but for now only do it on Darwin, Linux, and FreeBSD.
This prevents some load-time errors that have been seen in GitLab's gitaly server, and in a few other places.