Auto-generate CMake file lists in GitHub action #10592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
approved these changes
Sep 16, 2022
acozzette
force-pushed
the
cmake-file-generation
branch
from
e5b8b49 to
1daa296
Compare
|
I did test it out on my personal fork and confirmed that it worked there, but I guess the only way to know for sure that it works in the main repo is to submit it and see what happens. That's a good idea to shuffle the file list, I think I'll try that afterward as a way to confirm that the action works. |
|
Nice, that's more than anything I thought of! As long as the functionality works any breakages will likely just be from config/settings |
mkruskal-google
approved these changes
Sep 16, 2022
acozzette
force-pushed
the
cmake-file-generation
branch
from
8a69fef to
24e166e
Compare
This GitHub action will run after each pull request merge and will auto-update the file lists in in src/file_lists.cmake. The action will run as our bot account. I realized that if a bug somehow made the file generation non-idempotent, this could trigger an infinite loop of commits, so I put in an extra safeguard against that. If the previous commit was by "Protobuf Team Bot", the GitHub action will revert any local changes to ensure that no new commit will be made.
acozzette
force-pushed
the
cmake-file-generation
branch
from
24e166e to
1f203ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This GitHub action will run after each pull request merge and will auto-update the file lists in in src/file_lists.cmake. The action will run as our bot account.
I realized that if a bug somehow made the file generation non-idempotent, this could trigger an infinite loop of commits, so I put in an extra safeguard against that. If the previous commit was by "Protobuf Team Bot", the GitHub action will revert any local changes to ensure that no new commit will be made.