Fix 32-bit floating point JSON parsing of maximal values for C# #10514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanda-tarafa
approved these changes
Sep 8, 2022
Comment on lines
+589
to
+592
| [TestCase("3.4028236e38", typeof(InvalidProtocolBufferException))] | ||
| [TestCase("-3.4028236e38", typeof(InvalidProtocolBufferException))] |
There was a problem hiding this comment.
super tiny nit (and just so that is clear at first sight that the string format is not the problem, use the same format in the valid and invalid tests):
Suggested change
| [TestCase("3.4028236e38", typeof(InvalidProtocolBufferException))] | |
| [TestCase("-3.4028236e38", typeof(InvalidProtocolBufferException))] | |
| [TestCase("3.4028236e+38", typeof(InvalidProtocolBufferException))] | |
| [TestCase("-3.4028236e+38", typeof(InvalidProtocolBufferException))] |
There was a problem hiding this comment.
Hmm... both formats should work. I'll update the tests to have both "with +" and without.
jskeet
force-pushed
the
float-parsing
branch
from
5decb39 to
77bdd5e
Compare
jskeet
force-pushed
the
float-parsing
branch
from
77bdd5e to
3874b22
Compare
jskeet
force-pushed
the
float-parsing
branch
from
3874b22 to
fc1dbc6
Compare
mcy
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10509.