This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat: allow skipping go-test on certain OSes #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsenta
reviewed
Feb 6, 2023
laurentsenta
reviewed
Feb 6, 2023
| runs-on: ${{ format('{0}-latest', matrix.os) }} | ||
| name: ${{ matrix.os }} (go ${{ matrix.go }}) | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| submodules: recursive | ||
| - id: config | ||
| uses: protocol/.github/.github/actions/read-config@master | ||
| - uses: actions/setup-go@v3 |
There was a problem hiding this comment.
Could we reduce duplication? Around here we'd set env.SKIPPED=contains(fromJSON(steps.config.outputs.json).skipOSes, matrix.os). Then reuse SKIPPED below.
laurentsenta
approved these changes
Feb 6, 2023
galargh
added a commit
that referenced
this pull request
Feb 8, 2023
* Add option to skip `32-bit` go test (#412) Introduce an option to configure `go-test` to allow completely skipping `32-bit` tests. Fixes #388 * Run at most 1 dispatch job per ref (#414) * fix: check if git tag returns any results (#415) * make go generate print the commands it executs (#440) * use pull_request_target event for release-check workflow (#295) * Revert "include cross-package coverage in codecov" * Revert "Revert "include cross-package coverage in codecov"" * Make automerge a reusable workflow (#260) * move automerge from template to workflows * make automerge reusable and use it from new automerge template * pass parent job name to reusable automerge * check github actions yamls (#272) * check github actions yamls * make yaml linter happy about go-test * mention VS Code YAML extension in the readme * add info about other YAML checking extensions * make yaml checker more generic * use validate-yaml-schema action from mainline (#277) * upgrade lewagon/wait-on-check-action to v1.1.1 (#278) * always add a version.json file if it doesn't exist (#281) * fix go-test runner string * check if tag already exists in release-check (#287) * allow specifying custom PATH for 386 arch (#289) * use pull_request_target event for release-check workflow * add comment on missing version.json * chore: revert release checker path trigger change * chore: add footnote when non-docs files are modified with the release * fix: prev version calculation * feat: allow configuring custom go-test runners (#443) * feat: allow configuring custom go-test runners * docs: update readme to include info on configuration variables * feat: allow skipping go-test on certain OSes (#455) * feat: standarise JSON config reading * feat: allow skipping go-test on certain OSes * fix: go-test conditional * chore: show config after extracting it * chore: udpate actions and go modules (#458) * fix: source read-config from next for now * simplify Go version upgrade procedure (#280) * chore: simplify Go version upgrade procedure * chore: add default for the go-version input of release-check * Update .github/actions/copy-workflow-go/action.yml * Update configs/README.md Co-authored-by: Laurent Senta <[email protected]> --------- Co-authored-by: Laurent Senta <[email protected]> * Go through all the workflows and clean them up ahead of the next major release (#462) * chore: clean up deprecated set-output * chore: do not use substitution inside run * chore: do not use substitution in if * chore: skip env var brakets where possible * fix: env var substitution * fix: double toJSON * Update templates/.github/workflows/js-test-and-release.yml * feat: create gh releases in release-check/releaser workflows (#456) * feat: create gh releases in release-check/releaser workflows * fix: fill expr in release check workflow * fix: add missing gh token in release check * fix: add missing prev version env var in release check workflow * fix: release check in release check * chore: clean up obsolete step from releaser * fix: step outputs in release workflows * fix: labels in releaser * fix: action gh release * update go version to 1.20.x (#463) * update go version to 1.20.x * fix: go 1.20 upgrade * Revert "fix: go 1.20 upgrade" This reverts commit ceb72ef. * clean up where source ref was set to next (#464) * perform self-review before final release --------- Co-authored-by: Masih H. Derkani <[email protected]> Co-authored-by: Marten Seemann <[email protected]> Co-authored-by: Laurent Senta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #349
Description
This PR allows configuring uCI to skip go-test on certain OSes by providing a list of OSes that should be skipped in
go-test-config.jsonunderskipOSeskey.If there's a match, the most time consuming steps of the workflow will be skipped. The job itself won't because that would require us to split the job in two, where one would be used only for figuring out whether the other should be skipped, and we don't want to introduce the overhead of starting up two jobs.
Testing