This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Upgrade staticcheck to v0.3.0 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
What about using the official GitHub Action workflow, see #310?
I'm afraid we cannot use https://github.com/dominikh/staticcheck-action together with https://github.com/protocol/multiple-go-modules. |
|
Good point. Hadn't thought of that. That's mildly annoying, but not the end of the world. |
marten-seemann
approved these changes
Mar 30, 2022
galargh
added a commit
that referenced
this pull request
Apr 4, 2022
* Revert "include cross-package coverage in codecov" * Revert "Revert "include cross-package coverage in codecov"" * Make automerge a reusable workflow (#260) * move automerge from template to workflows * make automerge reusable and use it from new automerge template * pass parent job name to reusable automerge * check github actions yamls (#272) * check github actions yamls * make yaml linter happy about go-test * mention VS Code YAML extension in the readme * add info about other YAML checking extensions * make yaml checker more generic * use validate-yaml-schema action from mainline (#277) * upgrade lewagon/wait-on-check-action to v1.1.1 (#278) * always add a version.json file if it doesn't exist (#281) * fix go-test runner string * check if tag already exists in release-check (#287) * allow specifying custom PATH for 386 arch (#289) * go: update to 1.18.x (#307) * Upgrade staticcheck to v0.3.0 (#311) * increase sleep between PR creations to 10s * restore DEFAULT_BRANCH replacement Co-authored-by: Laurent Senta <[email protected]>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was successfully deployed to protocol/.github-test-target#37