Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit depth of BoundingSphereOctree #42

Closed
lojjic opened this issue May 13, 2020 · 0 comments
Closed

Limit depth of BoundingSphereOctree #42

lojjic opened this issue May 13, 2020 · 0 comments

Comments

@lojjic
Copy link
Collaborator

lojjic commented May 13, 2020

Objects with origins extremely near each other currently result in the BoundingSphereOctree we use for raycasting optimization becoming excessively deep. We should implement a minimum leaf size below which no further subdivision happens. This would likely improve performance in many cases, and may avoid some possible issues that could crop up as the node size approaches epsilon.
lojjic added a commit that referenced this issue May 19, 2020
@lojjic
fix(troika-3d): fix errors due to excessively deep BoundingSphereOctrees
a4b5797 
Fixes issue #42. Bounding spheres with centers extremely close together
would result in very deep trees, hurting search performance, and also
apparently causing invalid tree states due to floating point precision
quirks (though I couldn't identify how exactly.) This change rounds all
bounding sphere positions to a fixed precision which is then used
throughout for determining leaf coincidence.
@lojjic lojjic closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lojjic