-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider client timezone for deadline validation #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No on server side we want to store it as UTC. That's why the title is "CLIENT" timezone deadline validation.
Got it. I updated pull req. |
I think the timezone should come from browser, not from php.ini settings. Maybe I am wrong. |
Used JS datetime picker is converting deadline to UTC anyway. I'd say store it internally in the UTC, and based on i.e. user's TZ settings (this can be added) render date and time differently. |
@codeliner can you take a look into this? |
ping @codeliner |
sorry for the delay, I totally missed that issue (sometimes too much is going on on github) I'm with @prolic The client should send UTC and we take that date and construct the The date picker in the frontend should show local time but store and send UTC. That's the idea of the ticket |
ping @sbacelic |
nearly one year without activity, closing. |
Should fix issue #40