Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider client timezone for deadline validation #151

Closed
wants to merge 3 commits into from

Conversation

sbacelic
Copy link
Contributor

Should fix issue #40

Copy link
Member

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No on server side we want to store it as UTC. That's why the title is "CLIENT" timezone deadline validation.

@sbacelic
Copy link
Contributor Author

Got it. I updated pull req.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 24.504% when pulling ba4a5df on sbacelic:master into 6fba4a7 on prooph:master.

@prolic
Copy link
Member

prolic commented Dec 16, 2017

I think the timezone should come from browser, not from php.ini settings. Maybe I am wrong.

@codeliner?

@sbacelic
Copy link
Contributor Author

Used JS datetime picker is converting deadline to UTC anyway. I'd say store it internally in the UTC, and based on i.e. user's TZ settings (this can be added) render date and time differently.

@prolic
Copy link
Member

prolic commented Dec 23, 2017

@codeliner can you take a look into this?

@prolic
Copy link
Member

prolic commented Feb 3, 2018

ping @codeliner

@codeliner
Copy link
Member

sorry for the delay, I totally missed that issue (sometimes too much is going on on github)

I'm with @prolic The client should send UTC and we take that date and construct the DateTimeImmutable with time zone UTC.

The date picker in the frontend should show local time but store and send UTC. That's the idea of the ticket

@prolic
Copy link
Member

prolic commented May 23, 2018

ping @sbacelic

@prolic
Copy link
Member

prolic commented Nov 26, 2018

nearly one year without activity, closing.

@prolic prolic closed this Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants