Gracefully handle FileHistory decoding errors #1303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a corrupted history file, instead of raising a UnicodeDecodeError, malformed characters are replaced by
U+FFFD
(REPLACEMENT CHARACTER) during decoding.Currently, if a history file is malformed and contains invalid unicode characters, a UnicodeDecodeError is raised, which prevents the prompt from working (and cannot be handled properly).
Minimal working example (before fix):
Create malformed history
Example code:
Execution and output before fix: