Upgrade packages (needed for Node.js 7 compatibility) #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of mocha used so far relies on an outdated graceful-fs version that prints deprecation messages in Node.js 6 and will stop working in Node.js 7.
| "sinon": "^1.10.3", | ||
| "underscore": "~1.6.0" | ||
| "underscore": "^1.8.3" |
There was a problem hiding this comment.
We can't rely on Underscore to preserve compat between minor versions since they don't follow semver
|
Merged as cdfe0f3 but keeping Underscore at ~. Released as 2.1.2. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of mocha used so far relies on an outdated graceful-fs version
that prints deprecation messages in Node.js 6 and will stop working in
Node.js 7.