Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded nginx-ingress to 0.24.1 #199

Merged
merged 3 commits into from
Jun 14, 2019

Conversation

geekodour
Copy link
Contributor

upgraded nginx-ingress to 0.24.1 and also moved few ingress resources to other files.

this removed the default-backend deployment.

one change in the Ingress resource for grafana is not backward compatible
more info: https://kubernetes.github.io/ingress-nginx/examples/rewrite/#rewrite-target

Signed-off-by: Hrishikesh Barman [email protected]

Copy link
Contributor

@krasi-georgiev krasi-georgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you put the ingress-prometheus-meta into the prometheus-meta.yaml
and ingress-grafana into one of the grafana yml files?

Signed-off-by: Hrishikesh Barman <[email protected]>
Signed-off-by: Hrishikesh Barman <[email protected]>
@krasi-georgiev krasi-georgiev merged commit 76db6d6 into prometheus:master Jun 14, 2019
@krasi-georgiev
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants