Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert line payloads to string for debug logging #510

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Convert line payloads to string for debug logging #510

merged 1 commit into from
Jul 10, 2023

Conversation

sumeshpremraj
Copy link
Contributor

This avoids logging of bytes slices as Base64-encoded data, making it unreadable.

resolves #497

Copy link
Contributor

@matthiasr matthiasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@matthiasr matthiasr merged commit 871e2d8 into prometheus:master Jul 10, 2023
@sumeshpremraj sumeshpremraj deleted the spremraj/improve-network-debug-logging branch July 11, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent debug logging of line payloads from TCP listener
2 participants