Making mapperConfigDefaults public #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaantunes
force-pushed
the
gaantunes/mapperConfigDefaults-public
branch
3 times, most recently
from
9d8fda4 to
43d6325
Compare
matthiasr
approved these changes
Mar 15, 2023
…na Agent can instantiate MetricMapper without using InitFromYAMLString directly. Signed-off-by: Gabriel Antunes <[email protected]>
gaantunes
force-pushed
the
gaantunes/mapperConfigDefaults-public
branch
from
43d6325 to
24e2fc9
Compare
I think it was just missing my account auth on CircleCI, I authenticated and it ran succesfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is making the
mapperConfigDefaultsandmetricObjectivestructs insideMetricMapperobject public, so that Grafana Agent or any other application embedding this exporter can instatiateMetricMapperwithout using theInitFromYAMLStringdirectly.This is really helpful when you are not defining your configuration using YAML standard.