New metric for relayed lines #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-stanaka
force-pushed
the
relay-new-line-count-metric
branch
3 times, most recently
from
16e75a2 to
23ecab8
Compare
* Adding new simple test to relay package * Adding metric testing on relay * Adding new metric to relay * Adding new test section to check on metrics * Fixing linting problems on new code * Adding license headers on file Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka
force-pushed
the
relay-new-line-count-metric
branch
from
23ecab8 to
0de518d
Compare
|
@matthiasr here is the new PR. I somehow missed that header as well. Thx for the patience. |
matthiasr
approved these changes
May 6, 2022
matthiasr
added a commit
that referenced
this pull request
May 6, 2022
just in time for 0.22.5 :) Signed-off-by: Matthias Rampke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I am adding a new metric to address issue #427, it counts how many lines were buffered to be relayed.
Changes