Add lifecycle api #329
Merged
Add lifecycle api #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: glightfoot <[email protected]>
matthiasr
added a commit
that referenced
this pull request
Aug 21, 2020
with changelog entries for #325 and #329. Signed-off-by: Matthias Rampke <[email protected]>
|
Sorry to follow up on a closed PR, but is an empty reply expected? It results in non-zero exit code when using curl. I'd be happy to open an Issue if that's preferred. |
|
Yes, please do!
…On Tue, Jan 26, 2021, 05:01 jimdaga ***@***.***> wrote:
Sorry to follow up on a closed PR, but is an empty reply expected? It
results in non-zero exit code when using curl.
$ curl -X POST http://localhost:9102/-/quit
curl: (52) Empty reply from server
$ echo $?
52
I'd be happy to open an Issue if that's preferred.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#329 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABAEBRSR5Q4B2ZEOBY5CNDS3Y5ABANCNFSM4P2HZESQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327. Adds a lifecycle API with the same semantics as Prometheus. Moves the http serving to use a mux, and also moves starting the HTTP server to after the mapper is initialized.
@matthiasr