allow metrics with dashes when mapping #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| identifierRE = `[a-zA-Z_][a-zA-Z0-9_]+` | |||
| identifierRE = `[a-zA-Z_]+-?[a-zA-Z0-9_]+` | |||
There was a problem hiding this comment.
Thanks!
identifierRE is used not only in the regex that matches statsd metric lines, but also for the other two ones labelLineRE and metricNameRE. Those are for matching Prometheus label names and Prometheus metric names, both of which may not contain dashes.
If you want to allow dashes in statsd metric names, you'll have to isolate that change to just the regex that matches those.
macb
force-pushed
the
allow_hyphen_hostname
branch
from
19a7f72 to
c52befb
Compare
|
ok @juliusv, teased apart the statsd metric line so that it could be changed independent of the labels regex. I also added a test case for label names with |
macb
force-pushed
the
allow_hyphen_hostname
branch
from
c52befb to
411b071
Compare
|
@macb Cool, thanks! |
juliusv
added a commit
that referenced
this pull request
Oct 12, 2015
allow metrics with dashes when mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't entirely clear why this wasn't allowed. We have some systems that submit metrics with their hostname in the metric. Something in the form of
test-myhost01. This allows the mapper to match those.Actually doesn't fully meet the use case where the name may be
test-my-host01or something. Still working.