Fixes #191: crash on empty metric name #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Izaguirre <[email protected]>
Signed-off-by: Ivan Izaguirre <[email protected]>
matthiasr
requested changes
Mar 25, 2019
exporter.go
Outdated
| @@ -333,6 +333,10 @@ func (b *Exporter) handleEvent(event Event) { | |||
| metricName := "" | |||
| prometheusLabels := event.Labels() | |||
| if present { | |||
| if mapping.Name == "" { | |||
| log.Debugf("The mapping for match \"%v\" generates an empty metric name.", mapping.Match) | |||
There was a problem hiding this comment.
Please also add a metric to track this. On line 255 we are already (mis)using the eventStats counter to track negative increments, but I think it would be better if you set up a new metric vector for event errors, and also changed the negative-counter to use it.
There was a problem hiding this comment.
Also, please also add event.MetricName() to the log line, this will make it much easier to track down what input causes this.
Signed-off-by: Ivan Izaguirre <[email protected]>
|
This should be it. Tests for the telemetry counters could be cleaner but I don't know a way to reset them between tests. |
Signed-off-by: Ivan Izaguirre <[email protected]>
matthiasr
approved these changes
Mar 26, 2019
|
Wonderful, thank you very much! |
matthiasr
pushed a commit
that referenced
this pull request
Mar 26, 2019
add note about the metric change.
matthiasr
pushed a commit
that referenced
this pull request
May 15, 2019
* [CHANGE] Do not run as root in the Docker container by default ([#202](#202)) * [FEATURE] Add metric for count of events by action ([#193](#193)) * [FEATURE] Add metric for count of distinct metric names ([#200](#200)) * [FEATURE] Add UNIX socket listener support ([#199](#199)) * [FEATURE] Accept Datadog [distributions](https://docs.datadoghq.com/graphing/metrics/distributions/) ([#211](#211)) * [ENHANCEMENT] Add a health check to the Docker container ([#182](#182)) * [ENHANCEMENT] Allow inconsistent label sets ([#194](#194)) * [ENHANCEMENT] Speed up sanitization of metric names ([#197](#197)) * [ENHANCEMENT] Enable pprof endpoints ([#205](#205)) * [ENHANCEMENT] DogStatsD tag parsing is faster ([#210](#210)) * [ENHANCEMENT] Cache mapped metrics ([#198](#198)) * [BUGFIX] Fix panic if a mapping resulted in an empty name ([#192](#192)) * [BUGFIX] Ensure that there are always default quantiles if using summaries ([#212](#212)) * [BUGFIX] Prevent ingesting conflicting metric types that would make scraping fail ([#213](#213)) With #192, the count of events rejected because of negative counter increments has moved into the `statsd_exporter_events_error_total` metric, instead of being lumped in with the different kinds of successful events. Signed-off-by: Matthias Rampke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids crashing when escaping empty metric names.
The metrics are ignored and a message is logged.
@matthiasr