Bump prometheus/client_golang to v0.9.2 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <[email protected]>
Closed
|
Thank you! |
matthiasr
pushed a commit
that referenced
this pull request
Dec 17, 2018
I'd like to add more detail, but I'm not sure I understand the implications just yet, and they will probably change with #164. Signed-off-by: Matthias Rampke <[email protected]>
dhewg
added a commit
to dhewg/packages
that referenced
this pull request
Jan 3, 2019
This fixes the exact same build error reported at [0]. Upstream fixed it too, see [1], but I decided to use the minimal patch until a new version is released instead. [0] golang/go#29281 [1] prometheus/statsd_exporter#171 Signed-off-by: Andre Heider <[email protected]>
dhewg
added a commit
to dhewg/packages
that referenced
this pull request
Jan 4, 2019
This fixes the exact same build error reported at [0]. Upstream fixed it too, see [1], but I decided to use the minimal patch until a new version is released instead. [0] golang/go#29281 [1] prometheus/statsd_exporter#171 Signed-off-by: Andre Heider <[email protected]>
ClaymorePT
pushed a commit
to ClaymorePT/packages
that referenced
this pull request
Feb 12, 2019
This fixes the exact same build error reported at [0]. Upstream fixed it too, see [1], but I decided to use the minimal patch until a new version is released instead. [0] golang/go#29281 [1] prometheus/statsd_exporter#171 Signed-off-by: Andre Heider <[email protected]>
thiagoricciardi
pushed a commit
to thiagoricciardi/packages
that referenced
this pull request
Apr 3, 2019
This fixes the exact same build error reported at [0]. Upstream fixed it too, see [1], but I decided to use the minimal patch until a new version is released instead. [0] golang/go#29281 [1] prometheus/statsd_exporter#171 Signed-off-by: Andre Heider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Go version (1.11.4) breaks the build process because it changes the checksum of the
github.com/prometheus/procfsmodule. Bumping prometheus/client_golang to v0.9.2 solves the issue because it uses Go modules which removesprocfsas an indirect dependency.See prometheus/blackbox_exporter#395 and golang/go#29278 (comment) for more details.