Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore version in config files #923

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Ignore version in config files #923

merged 1 commit into from
Jul 19, 2023

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Jul 19, 2023

Re-add the version key, but omitempty so it is simply ignored for now.

Re-add the version key, but omitempty so it is simply ignored for now.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ requested review from roidelapluie and RichiH July 19, 2023 12:09
@SuperQ SuperQ merged commit 9e644eb into main Jul 19, 2023
@SuperQ SuperQ deleted the superq/version_ignore branch July 19, 2023 19:41
Copy link
Member

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stephan-windischmann-sky pushed a commit to stephan-windischmann-sky/snmp_exporter that referenced this pull request Oct 27, 2023
Re-add the version key, but omitempty so it is simply ignored for now.

Signed-off-by: SuperQ <[email protected]>
Signed-off-by: Stephan Windischmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants