Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for use of stronger AES and SHA crypto #595

Merged
merged 5 commits into from
Jan 9, 2021
Merged

Allow for use of stronger AES and SHA crypto #595

merged 5 commits into from
Jan 9, 2021

Conversation

marri5317
Copy link
Contributor

Update switch-cases to allow the use of stronger crypto pairs supported by GoSNMP

@brian-brazil
Copy link
Contributor

CI doesn't like this, also the generate readme will need updating.

@SuperQ Now that there's more of these, gosnmp should probably expose this as a map or something so we don't have to maintain this here.

generator/README.md Outdated Show resolved Hide resolved
generator/README.md Outdated Show resolved Hide resolved
@SuperQ
Copy link
Member

SuperQ commented Dec 29, 2020

Can you rebase your branch against master? That should fix the tests.

@SuperQ
Copy link
Member

SuperQ commented Dec 29, 2020

Ugh, every other CI run flip-flops the generator output.

@SuperQ
Copy link
Member

SuperQ commented Jan 6, 2021

Please rebase in order to pick up some fixes to the generator.

marri5317 and others added 5 commits January 7, 2021 19:56
Signed-off-by: Martijn van Hoof <[email protected]>
Signed-off-by: Martijn van Hoof <[email protected]>
Co-authored-by: Ben Kochie <[email protected]>
Signed-off-by: Martijn van Hoof <[email protected]>
Signed-off-by: Martijn van Hoof <[email protected]>
@marri5317
Copy link
Contributor Author

Should be good to merge now

@brian-brazil brian-brazil merged commit bbfea61 into prometheus:master Jan 9, 2021
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants