Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix do not expand envvars for empty config fields #1148

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

IvoGoman
Copy link
Contributor

Fixes an error loading the config, if any Auth section contains an empty Username, Password or PrivPassword
@SuperQ @RichiH

fixes #1145

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add some test cases for this.

@IvoGoman IvoGoman force-pushed the fix/config/envvar branch from 8992c92 to db62a1f Compare March 30, 2024 14:37
@IvoGoman
Copy link
Contributor Author

It would be good to add some test cases for this.

Agreed, I missed the config_test.go in the root directory.
Added a testcase for loading a SNMPv2 Auth Config without credentials specified. I believe the other cases are covered.

@SuperQ SuperQ merged commit 01f11ea into prometheus:main Mar 30, 2024
6 checks passed
@IvoGoman IvoGoman deleted the fix/config/envvar branch March 30, 2024 14:52
@SuperQ SuperQ mentioned this pull request May 10, 2024
SuperQ pushed a commit that referenced this pull request May 11, 2024
* [CHANGE] Improve generator parse error handling #1167
* [ENHANCEMENT] generator: Add generator HELP override #1106
* [ENHANCEMENT] Refactoring of Scrape process, fixing multiple module issues #1111
* [ENHANCEMENT] Skip using an interactive terminal in "make docker-generate". #1113
* [ENHANCEMENT] Add SNMPInflight metric #1119
* [FEATURE] Support for passing username, password & priv_password as env vars #1074
* [FEATURE] Add GoSNMP logger #1157
* [FEATURE] Add a "snmp_context" parameter to the URL #1163
* [BUGFIX] generator: curl failed #1094
* [BUGFIX] Fix SNMPv3 password configuration #1122
* [BUGFIX] generator: Update generator User-Agent #1133
* [BUGFIX] generator: fix mibs directory specification for parse_errors command #1135
* [BUGFIX] generator: remove extra character from dell iDrac-SMIv1 MIB #1141
* [BUGFIX] Fix do not expand envvars for empty config fields #1148

snmp.yml changes:
* Updated Cisco MIBs #1180
* Updated Cyberpower MIBs #1124
* Updated servertech_sentry3 #1090
* Added support for Dell iDrac  #1125
---------

Signed-off-by: Sebastian Schubert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNMPv2 Expansion of Environment Variables
2 participants