Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use empty label values in the grouping key #346

Merged
merged 1 commit into from
May 15, 2020

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented May 12, 2020

"Fixes" #344.

@matevz

README.md Outdated
If you are not using a client library that handles the encoding for you, you
can use encoding tools. For example, there is a command line tool `base64url`
(Debian package `basez`), which you could combine with `curl` to push from
the command line in the following way:

echo 'some_metric{foo="bar"} 3.14' | curl --data-binary @- http://pushgateway.example.org:9091/metrics/job/directory_cleaner/path@base64/$(echo -n '/var/tmp' | base64url)

* To use the grouping key `job="example",first_label="",second_label="foobar"`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not quite clear that the issue here is the empty label. I'd suggest something like "To use a grouping key with an empty label value such as ..."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, updated.

@brian-brazil
Copy link
Contributor

👍

@beorn7 beorn7 merged commit e0b39d1 into master May 15, 2020
@beorn7 beorn7 deleted the beorn7/doc branch May 15, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants