Adds support for prettifying rules file #11233
Conversation
Harkishen-Singh
changed the title
Harkishen-Singh
force-pushed
the
prettify_rules_files
branch
from
09abdac
to
2873321
Compare
Harkishen-Singh
changed the title
Signed-off-by: Harkishen-Singh <[email protected]> This comment adds support for prettifying rules file accepted from `promtool prettify rules <files>`. It also adds support for prettifying a single PromQL expression via `promtool prettify query <promql-expr>`.
Harkishen-Singh
force-pushed
the
prettify_rules_files
branch
from
2873321
to
bf0b364
Compare
| groups: | ||
| - name: Test |
There was a problem hiding this comment.
This output is from encoding yaml.Node. The indentation looks strange. I am not sure how to fix this.
There was a problem hiding this comment.
@Harkishen-Singh SetIndent(2) on the v3 encoder will change the indent to 2 spaces rather than 4. However, to prevent the sequence indicator being included in the indentation you'd need to pull in go-yaml/yaml#753, probably easiest way would be to switch to the upcoming fork being used in kube/kustomize kubernetes-sigs/yaml#72
|
Hello @Harkishen-Singh, we have looked at this during the bug scrub. I will review this, in the meantime, are you willing to rebase the pull request? Thanks! |
|
Looking at this during the bug scrub again. @Harkishen-Singh doesn't seem to be able to come back to this. @roidelapluie how should we proceed here? Since you wanted to review this anyway, could you just take it over, do the rebase and any changes you feel necessary, and then we review it among ourselves? |
|
We came back around to this at the bug-scrub; since there was no update in 9 months we will close. Feel free to re-open if you do come back to it. |
Signed-off-by: Harkishen-Singh [email protected]
This comment adds support for prettifying rules file
accepted from
promtool prettify rules <files>.It also adds support for prettifying a single PromQL expression via
promtool prettify query <promql-expr>.