Add missing cpuinfo support for armv6l #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #257 added basic multiplatform support for cpuinfo. Due to this change, this library does not compile on 32-bit ARM CPUs, e.g. the armv7l in a Raspberry Pi 3b. I think this PR should solve this problem. Signed-off-by: Tobias Gies <[email protected]>
|
Hi @discordianfish, @SuperQ – you approved #257 and the follow-up #288. Could you have a look at this one? |
|
I'm wondering if we should add a default cpuinfo flag which just returns an error about being an unsupported platform. That way at least the library would compile on the unknown platforms instead of failing to compile. |
|
Good question. I actually prefer a failure to compile to finding out the library won't work at runtime, if I can. In this case, would love it if the error message could be somehow made clearer than just "cpuInfo? Never 'heard of it". |
|
Yeah not sure what is better. Let's discuss that in an issue or future PR though, this LGTM |
Closed
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
PR prometheus#257 added basic multiplatform support for cpuinfo. Due to this change, this library does not compile on 32-bit ARM CPUs, e.g. the armv7l in a Raspberry Pi 3b. I think this PR should solve this problem. Signed-off-by: Tobias Gies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainer,
PR #257 added basic multiplatform support for cpuinfo.
Due to this change, this project does not compile on 32-bit ARM CPUs, e.g. the armv7l in a Raspberry Pi 3b. I think this PR should solve this problem.