add flush request and time spend flushing diskstats for kernel 5.5+ #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: binjip978 <[email protected]>
blockdevice/stats.go
Outdated
| if err != nil && err != io.EOF { | ||
| return diskstats, err | ||
| } | ||
| if d.IoStatsCount == 14 || d.IoStatsCount == 18 { | ||
| if d.IoStatsCount == 14 || d.IoStatsCount == 18 || d.IoStatsCount == 20 { |
There was a problem hiding this comment.
I don't like this condition. I'd rather check if it's at least 14 or just get rid of it altogether.
There was a problem hiding this comment.
Yeah, I think that would be better assuming that sscanf doesn't fail on more than 20 fields.
Signed-off-by: binjip978 <[email protected]>
discordianfish
approved these changes
May 12, 2020
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
…rometheus#289) * add flush request and time spend flushing diskstats for kernel 5.5+ Signed-off-by: binjip978 <[email protected]> * add diskstats if at least 14 params are present Signed-off-by: binjip978 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: binjip978 [email protected]