Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collector: implement node_boot_time_seconds for OpenBSD/NetBSD/Darwin #901

Merged
merged 2 commits into from
Apr 17, 2018
Merged

collector: implement node_boot_time_seconds for OpenBSD/NetBSD/Darwin #901

merged 2 commits into from
Apr 17, 2018

Conversation

mischief
Copy link
Contributor

No description provided.

@mischief
Copy link
Contributor Author

note this changes the user interface slightly - new collector named boottime, and node_boot_time_seconds is no longer exposed in exec collector for freebsd/dragonfly.

is there any problem with that? should i follow up with a docs update?

@SuperQ
Copy link
Member

SuperQ commented Apr 15, 2018

Please update the collectors list in the README, and add a [CHANGES] CHANGELOG entry.

@mischief mischief changed the title collector: implement node_boot_time_seconds for OpenBSD/NetBSD collector: implement node_boot_time_seconds for OpenBSD/NetBSD/Darwin Apr 15, 2018
@SuperQ
Copy link
Member

SuperQ commented Apr 15, 2018

Tested on Darwin, works great. Just need the docs update and we're good to go.

@mischief
Copy link
Contributor Author

updated README.md and CHANGELOG.md, PTAL

SuperQ
SuperQ approved these changes Apr 15, 2018
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachfi
Copy link
Contributor

zachfi commented Apr 16, 2018

@mischief As an aside, are you running this on OpenBSD? I looked for a port, but didn't see it. I'm planning to run this on OpenBSD soon, but wondered how others were doing so.

@mischief
Copy link
Contributor Author

@xaque208 yes, i am running node_exporter on OpenBSD. there is no port, i've built it with go myself.

fortunately somebody has ported prometheus and grafana quite recently, and they are available as packages in OpenBSD 6.3. i used to install them by hand...

@SuperQ SuperQ merged commit f6008b2 into prometheus:master Apr 17, 2018
@mischief mischief deleted the bsd_boottime branch April 17, 2018 06:00
@zachfi
Copy link
Contributor

zachfi commented Apr 25, 2018

@mischief Thanks. I got node_exporter running on all my OpenBSD systems at home this last week. Happy to be running it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischief @SuperQ @zachfi