Fix memory corruption when number of filesystems > 16 #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergenhoetzel
force-pushed
the
fix-getfsstat-memory-corruption
branch
from
2282d8d to
483111b
Compare
|
Good catch. I just merged #898, which should fix the build errors for you. |
juergenhoetzel
force-pushed
the
fix-getfsstat-memory-corruption
branch
from
483111b to
222327b
Compare
Thanks. I rebased. I'm not sure what failed on buidkite. |
SuperQ
requested changes
Apr 15, 2018
collector/filesystem_freebsd.go
Outdated
| return nil, err | ||
| } | ||
| buf := make([]unix.Statfs_t, n) | ||
| n, err = unix.Getfsstat(buf, noWait) |
There was a problem hiding this comment.
The build failure says this should be _, err = ....
collector/filesystem_freebsd.go:49:2: this value of n is never used (SA4006)
There was a problem hiding this comment.
Oh, no, that's wrong. It should be buf, err = ....
There was a problem hiding this comment.
Oh, no, that's wrong. It should be buf, err = ...
RETURN VALUES
Upon successful completion, the number of statfs structures is returned.
Otherwise, -1 is returned and the global variable errno is set to
indicate the error.
Signed-off-by: Juergen Hoetzel <[email protected]>
juergenhoetzel
force-pushed
the
fix-getfsstat-memory-corruption
branch
from
222327b to
4a63cb2
Compare
|
Thanks. Fixed it. |
|
LGTM |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Juergen Hoetzel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this crash:
The doubling of the array size (in the for loop) doesn't help. The
getfsstathas already written beyond the end of the array. The correct way is to callgetfsstatwith anil/nullparameter to get the number of entries.