Greatly reduce the metrics vmstat returns by default. #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobie
reviewed
Mar 29, 2018
|
In general, makes sense and LGTM but I'd also like to keep oom_kill. |
How exactly is that spelled? My kernel doesn't have it. |
|
Oh interesting. Here it is: |
brian-brazil
force-pushed
the
vmstat-opt
branch
from
02fd314 to
ca5c563
Compare
SuperQ
force-pushed
the
vmstat-opt
branch
2 times, most recently
from
2511883 to
bed25c4
Compare
|
@discordianfish What kernel version is that? I don't see |
Vmstat has over 100 fields, most of which are highly detailed debug information. Trim this down to only essential fields by default, configurable by flag. Signed-off-by: Brian Brazil <[email protected]>
brian-brazil
force-pushed
the
vmstat-opt
branch
from
bed25c4 to
fe2af31
Compare
SuperQ
force-pushed
the
vmstat-opt
branch
2 times, most recently
from
4d2f9e3 to
f37f918
Compare
* Add oom_kill to fixture. * Update e2e outputs. * Put regexp in order. Signed-off-by: Ben Kochie <[email protected]>
|
👍 for oom_kill, looks very useful. We have it on our new 4.15 kernels. It seems to have been introduced after at least 4.10.15 (which is our second newest kernel version). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vmstat has over 100 fields, most of which are highly
detailed debug information. Trim this down to only
essential fields by default, configurable by flag.
Signed-off-by: Brian Brazil [email protected]
@SuperQ This knocks 112 metrics or 14% off a node exporter on my laptop. I think bar a few keys ones, these are too detailed to keep given how many there are.