Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop exec_ in boot_timestamp_seconds on *bsd #839

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

discordianfish
Copy link
Member

This closes #827.

Not sure the exec_ prefix makes sense for the other metrics either..
And I don't have access to a freebsd machine to test this.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree, the exec subsystem isn't necessary.

@discordianfish
Copy link
Member Author

So should I drop exec_ everywhere then?

@SuperQ SuperQ force-pushed the fish-bds-boottime-drop-exec branch from d5a9c0d to 0d0797a Compare March 6, 2018 15:25
@SuperQ SuperQ force-pushed the fish-bds-boottime-drop-exec branch from 0d0797a to a6e91f6 Compare March 8, 2018 11:44
@SuperQ
Copy link
Member

SuperQ commented Mar 8, 2018

@discordianfish Rebased with the new circleci config, \o/

@SuperQ SuperQ merged commit 424ca8e into master Mar 8, 2018
@SuperQ SuperQ deleted the fish-bds-boottime-drop-exec branch March 8, 2018 11:59
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop exec_ in boot_timestamp_seconds on freebsd, dragonfly
2 participants