Cleanup NFS metrics #834
Merged
Cleanup NFS metrics #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update `nfs` metric names to match `nfsd`. * Remove uneeded `tcp` label from TCP connections metric. * Remove uneeded `v` on `nfsd` metrics. * Enable all `nfs` v4 client metrics. * Remove `nfs` metric name overrides.
mdlayher
approved these changes
Feb 20, 2018
collector/nfs_linux.go
Outdated
| prometheus.BuildFQName(namespace, nfsSubsystem, "net_reads_total"), | ||
| "Number of reads at the network layer.", | ||
| prometheus.BuildFQName(namespace, nfsSubsystem, "packets_total"), | ||
| "Total NFSd network packets (sent+recieved) by protocol type.", |
SuperQ
force-pushed
the
superq/nfs_refactor
branch
from
f12adb2 to
3fd3189
Compare
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Cleanup NFS metrics * Update `nfs` metric names to match `nfsd`. * Remove uneeded `tcp` label from TCP connections metric. * Remove uneeded `v` on `nfsd` metrics. * Enable all `nfs` v4 client metrics. * Remove `nfs` metric name overrides. * Add ppc64le fixture. * Fix typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nfsmetric names to matchnfsd.tcplabel from TCP connections metric.vonnfsdmetrics.nfsv4 client metrics.nfsmetric name overrides.