updates for zfsonlinux 0.7.5 #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collector/zfs_linux.go
Outdated
| return fmt.Errorf("could not parse expected integer value for %q", key) | ||
| // kstat data type (column 2) should be KSTAT_DATA_UINT64 (4), otherwise ignore | ||
| // TODO: when other KSTAT_DATA_* types arrive, much of this will need to be restructured | ||
| if parts[1] == "4" { |
There was a problem hiding this comment.
I think we should define const for this to make it a bit more readable.
There was a problem hiding this comment.
good idea! I'll include a comment for the cross-reference to zfsonlinux code, too.
|
Regarding backwards compatibility:
Tested against ZFS v0.6.5.6 (as delivered in Ubuntu 16.04) and ZFS v0.7.5 |
discordianfish
approved these changes
Jan 16, 2018
…ult from ZFS bugs
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* updates for zfsonlinux 0.7.5 * add constants for KSTAT_DATA_* types * added e2e test for negative values represented by uint64 that can result from ZFS bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics available in zfsonlinux version 0.7.5.
Changes failure handling when zfs stats files do not exist to maintain backwards compatibility with older zfsonlinux releases.