Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smartmon.sh textfile script #700

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Fix smartmon.sh textfile script #700

merged 1 commit into from
Oct 18, 2017

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Oct 13, 2017

When there are no SMART compatible devices (Raspberry Pi for example) an
error is returned, but the return code is still 0.

# scan_smart_devices: glob(3) aborted matching pattern /dev/discs/disc*

  • Remove unused disks variable.
  • Filter for only valid /dev devices.

When there are no SMART compatible devices (Raspberry Pi for example) an
error is returned, but the return code is still 0.

`# scan_smart_devices: glob(3) aborted matching pattern /dev/discs/disc*`

* Remove unused `disks` variable.
* Filter for only valid `/dev` devices.
@SuperQ SuperQ requested a review from mdlayher October 13, 2017 16:14
Copy link
Contributor

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 1824ac3 into master Oct 18, 2017
@SuperQ SuperQ deleted the bjk/smartmon_empty branch October 18, 2017 05:37
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
When there are no SMART compatible devices (Raspberry Pi for example) an
error is returned, but the return code is still 0.

`# scan_smart_devices: glob(3) aborted matching pattern /dev/discs/disc*`

* Remove unused `disks` variable.
* Filter for only valid `/dev` devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants