Migrate dashboards to new grafonnet library #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critchtionary
force-pushed
the
update-dashboard
branch
from
0ad1bcf to
5cd5703
Compare
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
critchtionary
force-pushed
the
update-dashboard
branch
from
5cd5703 to
7f56387
Compare
janhorstmann
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Hey @critchtionary ,
overall LGTM, just something I noticed:
when grafana migrates the original dashboards it adds
"fieldConfig": { "defaults": { "custom": { "showPoints": "never" }
to the timeSeries panel. Should tsCustom.withShowPoints('never') be added to timeSeries panels?
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Auto seemed to be not showing them, but have changed to never. |
|
Is there any blocker remaining on this? |
janhorstmann
added a commit
to osism/kolla-operations
that referenced
this pull request
Dec 7, 2024
As reviewing/merging the pull requests to update the dashboards for the node-exporter and prometheus mixins takes a long time ([1]), we use the mixins from the pull requests directly. This may be reverted once the pull requests are merged. [1] prometheus/node_exporter#3147 prometheus/prometheus#15334 Signed-off-by: Jan Horstmann <[email protected]>
janhorstmann
added a commit
to osism/kolla-operations
that referenced
this pull request
Dec 7, 2024
As reviewing/merging the pull requests to update the dashboards for the node-exporter and prometheus mixins takes a long time ([1]), we use the mixins from the pull requests directly. This may be reverted once the pull requests are merged. [1] prometheus/node_exporter#3147 prometheus/prometheus#15334 Signed-off-by: Jan Horstmann <[email protected]>
SuperQ
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated away from deprecated Grafonnet library. This replaces panels using Angular JS which are disabled by default in Grafana 11 and will be unsupported in Grafana 12.
Fixes #3046